Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(952)

Issue 258953008: Add more tracing for launching Android Services. (Closed)

Created:
6 years, 7 months ago by ppi
Modified:
6 years, 7 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add more tracing for launching Android Services. This CLs adds trace events for ChildProcessLauncher::start() and ChildServiceConnection::bind(), improving visibility of the service startup events in traces. BUG=363121 R=yfriedman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ppi
Hello Yaron, please take a look.
6 years, 7 months ago (2014-04-28 14:48:37 UTC) #1
Yaron
lgtm
6 years, 7 months ago (2014-04-28 15:59:55 UTC) #2
ppi
The CQ bit was checked by ppi@chromium.org
6 years, 7 months ago (2014-04-28 16:09:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/258953008/1
6 years, 7 months ago (2014-04-28 16:09:20 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 21:13:39 UTC) #5
Message was sent while issue was closed.
Change committed as 266660

Powered by Google App Engine
This is Rietveld 408576698