Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258953005: Renaming --enable-font-smoothing cmd line argument to --enable-font-antialiasing (Closed)

Created:
6 years, 7 months ago by Dominik Röttsches
Modified:
6 years, 7 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, abarth-chromium, danakj, dglazkov+blink, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Renaming --enable-font-smoothing cmd line argument to --enable-font-antialiasing BUG=367082 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172974

Patch Set 1 #

Total comments: 1

Patch Set 2 : Preparing for landing this as a 4 sided patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M Source/platform/LayoutTestSupport.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/LayoutTestSupport.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/fonts/win/FontPlatformDataWin.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebKit.cpp View 1 1 chunk +14 lines, -2 lines 0 comments Download
M public/web/WebKit.h View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Dominik Röttsches
6 years, 7 months ago (2014-04-28 12:18:35 UTC) #1
eae
LGTM
6 years, 7 months ago (2014-04-28 14:51:58 UTC) #2
abarth-chromium
LGTM https://codereview.chromium.org/258953005/diff/1/public/web/WebKit.h File public/web/WebKit.h (right): https://codereview.chromium.org/258953005/diff/1/public/web/WebKit.h#newcode79 public/web/WebKit.h:79: BLINK_EXPORT bool fontAntialiasingEnabledForTest(); We could move these input ...
6 years, 7 months ago (2014-04-28 17:42:27 UTC) #3
Dominik Röttsches
On 2014/04/28 17:42:27, abarth wrote: > LGTM Thanks, Emil & Adam! - Could you also ...
6 years, 7 months ago (2014-04-28 19:31:36 UTC) #4
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 7 months ago (2014-04-30 09:02:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/258953005/20001
6 years, 7 months ago (2014-04-30 09:03:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 09:39:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 09:39:32 UTC) #8
Dominik Röttsches
The CQ bit was checked by dominik.rottsches@intel.com
6 years, 7 months ago (2014-04-30 10:46:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominik.rottsches@intel.com/258953005/40001
6 years, 7 months ago (2014-04-30 10:46:13 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 11:50:42 UTC) #11
Message was sent while issue was closed. 
Change committed as 172974

Powered by Google App Engine
This is Rietveld 408576698