Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 258953004: Fix a crash on closing cookies and site info bubble. (Closed)

Created:
6 years, 7 months ago by babu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a crash on closing cookies and site info bubble. Add NULL check for window in GetNativeThemeForWindow() to avoid a crash. BUG=367698 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
babu
6 years, 7 months ago (2014-04-28 12:20:43 UTC) #1
Evan Stade
lgtm
6 years, 7 months ago (2014-04-28 18:30:09 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 7 months ago (2014-04-28 18:30:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/258953004/1
6 years, 7 months ago (2014-04-28 18:32:04 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 18:40:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 18:40:43 UTC) #6
babu
+jochen@ for LGTM from OWNER.
6 years, 7 months ago (2014-04-29 08:04:55 UTC) #7
babu
6 years, 7 months ago (2014-04-29 08:08:24 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 7 months ago (2014-04-29 13:36:09 UTC) #9
babu
The CQ bit was checked by sudarsana.nagineni@intel.com
6 years, 7 months ago (2014-04-29 13:43:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarsana.nagineni@intel.com/258953004/1
6 years, 7 months ago (2014-04-29 13:43:40 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 23:07:21 UTC) #12
Message was sent while issue was closed.
Change committed as 266989

Powered by Google App Engine
This is Rietveld 408576698