Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: Source/core/html/forms/TextFieldInputType.cpp

Issue 258953002: Caret position after updating value IDL attribute of unfocused INPUT element is incompatible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/forms/TextFieldInputType.cpp
diff --git a/Source/core/html/forms/TextFieldInputType.cpp b/Source/core/html/forms/TextFieldInputType.cpp
index 1b78abe81c6802df9dd34458a9f75859217cdbb0..a5b1aa72825f4014b75a7f8ae4e96d491c76d210 100644
--- a/Source/core/html/forms/TextFieldInputType.cpp
+++ b/Source/core/html/forms/TextFieldInputType.cpp
@@ -160,8 +160,6 @@ void TextFieldInputType::setValue(const String& sanitizedValue, bool valueChange
unsigned max = visibleValue().length();
if (input->focused())
input->setSelectionRange(max, max);
- else
- input->cacheSelectionInResponseToSetValue(max);
tkent 2014/04/28 00:33:40 What happens if selectionStart=selectionEnd=3 befo
harpreet.sk 2014/04/28 16:07:55 In the above case the caret is place at end of tex
if (!valueChanged)
return;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698