Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: chrome/browser/manifest/manifest_icon_selector.h

Issue 2589503002: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)
Patch Set: Merge branch 'master' into dp_px Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/manifest/manifest_icon_selector.h
diff --git a/chrome/browser/manifest/manifest_icon_selector.h b/chrome/browser/manifest/manifest_icon_selector.h
index 5efd3be9314b7acd67e5f7541df89da4b4bb2b26..13fc4deb07301f76642ed5ac1a7084d67fde6b2e 100644
--- a/chrome/browser/manifest/manifest_icon_selector.h
+++ b/chrome/browser/manifest/manifest_icon_selector.h
@@ -21,16 +21,14 @@ class ManifestIconSelector {
// If/when this class is generalized, it may be a good idea to switch this to
// taking in pixels, instead.
//
- // Any icon returned will be close as possible to |ideal_icon_size_in_dp|
- // with a size not less than |minimum_icon_size_in_dp|.
+ // Any icon returned will be close as possible to |ideal_icon_size_in_px|
+ // with a size not less than |minimum_icon_size_in_px|.
//
// Returns the icon url if a suitable icon is found. An empty URL otherwise.
static GURL FindBestMatchingIcon(
const std::vector<content::Manifest::Icon>& icons,
- int ideal_icon_size_in_dp,
- int minimum_icon_size_in_dp);
-
- static int ConvertIconSizeFromDpToPx(int icon_size_in_dp);
+ int ideal_icon_size_in_px,
+ int minimum_icon_size_in_px);
private:
ManifestIconSelector(int ideal_icon_size_in_px,
« no previous file with comments | « chrome/browser/manifest/manifest_icon_downloader.cc ('k') | chrome/browser/manifest/manifest_icon_selector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698