Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: chrome/browser/android/webapk/webapk_update_data_fetcher.cc

Issue 2589503002: Use exact pixel sizes instead of dip in webapp/WebAPK installability code (Closed)
Patch Set: Merge branch 'master' into dp_px Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_update_data_fetcher.cc
diff --git a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
index a5a20efebe050d58bcb9d3074a7fff60b8fd0524..53a944e6afaae8181b5262efa0eb85924cd964e5 100644
--- a/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
+++ b/chrome/browser/android/webapk/webapk_update_data_fetcher.cc
@@ -108,10 +108,10 @@ void WebApkUpdateDataFetcher::FetchInstallableData() {
return;
InstallableParams params;
- params.ideal_icon_size_in_dp =
- ShortcutHelper::GetIdealHomescreenIconSizeInDp();
- params.minimum_icon_size_in_dp =
- ShortcutHelper::GetMinimumHomescreenIconSizeInDp();
+ params.ideal_icon_size_in_px =
+ ShortcutHelper::GetIdealHomescreenIconSizeInPx();
+ params.minimum_icon_size_in_px =
+ ShortcutHelper::GetMinimumHomescreenIconSizeInPx();
params.check_installable = true;
params.fetch_valid_icon = true;
InstallableManager::CreateForWebContents(web_contents());
« no previous file with comments | « chrome/browser/android/shortcut_helper.cc ('k') | chrome/browser/android/webapps/add_to_homescreen_data_fetcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698