Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: mojo/system/core_impl.h

Issue 25895002: Simple shell that loads a dll and calls an entrypoint function passing in a handle to a pipe create… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/shell/sample_app.cc ('K') | « mojo/shell/switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/core_impl.h
diff --git a/mojo/system/core_impl.h b/mojo/system/core_impl.h
index 1417a06d60a7fa44bc4a328bc17d61a0108ee9e4..cce3a85bb8294ecfd636a21889b44a7e374d18d7 100644
--- a/mojo/system/core_impl.h
+++ b/mojo/system/core_impl.h
@@ -25,7 +25,7 @@ class CoreTestBase;
// the (obvious) exception of |Init()|, which must be called first (and the call
// completed) before making any other calls, all the public methods are
// thread-safe.
-class CoreImpl {
+class SYSTEM_EXPORT CoreImpl {
Ben Goodger (Google) 2013/10/03 17:45:18 needed so shell's main() can init.
darin (slow to review) 2013/10/04 21:47:14 yeah, with this code broken out as a separate DLL,
Ben Goodger (Google) 2013/10/07 23:48:44 I can think of a variety of ways to make this more
public:
static void Init();
« mojo/shell/sample_app.cc ('K') | « mojo/shell/switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698