Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/bookmarks/bookmark_node_data.cc

Issue 25894003: Don't write URLs to clipboard from views omnibox as hyperlinks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make behaviour consistent across platforms Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_node_data.cc
diff --git a/chrome/browser/bookmarks/bookmark_node_data.cc b/chrome/browser/bookmarks/bookmark_node_data.cc
index b1d201fa709f01562dcfae409646c967ef29a49f..d8d9501116e89533a4de30eb135cf8b185d6c9cb 100644
--- a/chrome/browser/bookmarks/bookmark_node_data.cc
+++ b/chrome/browser/bookmarks/bookmark_node_data.cc
@@ -143,7 +143,11 @@ void BookmarkNodeData::WriteToClipboard() const {
const std::string url = elements[0].url.spec();
scw.WriteBookmark(title, url);
- scw.WriteHyperlink(title, url);
+
+ // Previously scw.WriteHyperlink was called here. Purposfully don't write
Peter Kasting 2013/10/07 22:19:23 Nit: Shorter and more direct: "Don't call scw.Writ
+ // hyperlink data, since some rich text editors will change fonts when
+ // such data is pasted in; besides, most such editors auto-linkify at some
+ // point anyway.
// Also write the URL to the clipboard as text so that it can be pasted
// into text fields. We use WriteText instead of WriteURL because we don't

Powered by Google App Engine
This is Rietveld 408576698