Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 25894003: Don't write URLs to clipboard from views omnibox as hyperlinks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 9f39b0e20e701743e6be1448a399f816ec0bf3dc..081faf6a05cd86693ec2f3dd3fa22c4d69553845 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -1614,8 +1614,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CopyURLToClipboard) {
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetPlainTextFormatType(), ui::Clipboard::BUFFER_STANDARD));
- // The Mac is the only platform which doesn't write html.
-#if !defined(OS_MACOSX)
+ // Mac and Windows don't write HTML.
+#if !defined(OS_MACOSX) && !defined(OS_WIN)
Peter Kasting 2013/10/05 00:42:27 Seems like on these platforms we should EXPECT_FAL
scottmg 2013/10/07 22:16:27 Done.
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetHtmlFormatType(), ui::Clipboard::BUFFER_STANDARD));
#endif
@@ -1661,8 +1661,8 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewTest, CutURLToClipboard) {
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetPlainTextFormatType(), ui::Clipboard::BUFFER_STANDARD));
- // The Mac is the only platform which doesn't write html.
-#if !defined(OS_MACOSX)
+ // Mac and Windows don't write HTML.
+#if !defined(OS_MACOSX) && !defined(OS_WIN)
EXPECT_TRUE(clipboard->IsFormatAvailable(
ui::Clipboard::GetHtmlFormatType(), ui::Clipboard::BUFFER_STANDARD));
#endif

Powered by Google App Engine
This is Rietveld 408576698