Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 25894003: Don't write URLs to clipboard from views omnibox as hyperlinks (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index 0362f4932b8168c439b3c2d993baad4bf724f26d..6b58d0c5d2e2e5e15a0b7646364295a95847fa87 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -737,15 +737,9 @@ void OmniboxViewViews::OnAfterCutOrCopy() {
bool write_url;
model()->AdjustTextForCopy(GetSelectedRange().GetMin(), IsSelectAll(),
&selected_text, &url, &write_url);
Peter Kasting 2013/10/03 23:46:43 Can we kill write_url entirely?
scottmg 2013/10/04 00:07:12 No, we use it e.g. below when determining if the d
- if (write_url) {
- BookmarkNodeData data;
- data.ReadFromTuple(url, selected_text);
- data.WriteToClipboard();
- } else {
- ui::ScopedClipboardWriter scoped_clipboard_writer(
- ui::Clipboard::GetForCurrentThread(), ui::Clipboard::BUFFER_STANDARD);
- scoped_clipboard_writer.WriteText(selected_text);
- }
+ ui::ScopedClipboardWriter scoped_clipboard_writer(
+ ui::Clipboard::GetForCurrentThread(), ui::Clipboard::BUFFER_STANDARD);
+ scoped_clipboard_writer.WriteText(selected_text);
}
void OmniboxViewViews::OnGetDragOperationsForTextfield(int* drag_operations) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698