third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h - Issue 2589383002: Do not push the custom element construction stack in some cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

Issue 2589383002: Do not push the custom element construction stack in some cases. (Closed)

Patch Set: Remove redundant scope and rebase. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/imported/wpt/custom-elements/parser/parser-uses-constructed-element-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

index 27eb3dda4c96eb076673054ad34a1b61b6b92945..eac09b8080bf0b0f82d26f115b53d59792d20928 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.h

@@ -73,7 +73,9 @@ class CORE_EXPORT ScriptCustomElementDefinition final

// Implementations of |CustomElementDefinition|

ScriptValue getConstructorForScript() final;

bool runConstructor(Element*) override;

- Element* runConstructor();

+ // Calls the constructor. The script scope, etc. must already be set up.

+ Element* callConstructor();

void runCallback(v8::Local<v8::Function>,

Element*,