chrome/browser/resources/settings/device_page/display_overscan_dialog.js - Issue 2589353002: MD Settings: Display > Overscan: Update text and fix focus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/device_page/display_overscan_dialog.js

Issue 2589353002: MD Settings: Display > Overscan: Update text and fix focus (Closed)

Patch Set: Feedback Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/device_page/display_overscan_dialog.html ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/device_page/display_overscan_dialog.js

diff --git a/chrome/browser/resources/settings/device_page/display_overscan_dialog.js b/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

index 109301b9c8aad571af0e6ae51c6cadc5e92efa16..e9f245c42c17d4f6faca2abcd21d028620077d5c 100644

--- a/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

+++ b/chrome/browser/resources/settings/device_page/display_overscan_dialog.js

@@ -32,13 +32,17 @@ Polymer({

open: function() {

this.keyHandler_ = this.handleKeyEvent_.bind(this);

- this.addEventListener('keydown', this.keyHandler_);

+ // We need to attach the event listener to |window|, not |this| so that

+ // changing focus does not prevent key events from occuring.

+ window.addEventListener('keydown', this.keyHandler_);

this.comitted_ = false;

this.$.dialog.showModal();

+ // Don't focus 'reset' by default. 'Tab' will focus 'OK'.

+ this.$$('#reset').blur();

close: function() {

- this.removeEventListener('keydown', this.keyHandler_);

+ window.removeEventListener('keydown', this.keyHandler_);

this.displayId = ''; // Will trigger displayIdChanged_.