Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 258933009: Revert of Store default search provider data in dictionary pref. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Store default search provider data in dictionary pref. (https://codereview.chromium.org/229763005/) Reason for revert: Speculative revert for introducing lots of leaks. See: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2026 Original issue's description: > Store default search provider data in dictionary pref, and add DefaultSearchManager class to handle the reading and writing of this pref (DefaultSearchManager will eventually all default search related concerns). > > This pref will be used to persist data about user-selected > default search providers. In future CLs, support will be added for default search providers set by policy and sync. > > > BUG=365762 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266479 BUG=365762 TBR=gab, erikwright, Peter Kasting, Cait Phillips NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -401 lines) Patch
D chrome/browser/search_engines/default_search_manager.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/search_engines/default_search_manager.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D chrome/browser/search_engines/default_search_manager_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Michael Achenbach
Created Revert of Store default search provider data in dictionary pref.
6 years, 7 months ago (2014-04-28 13:58:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/258933009/1
6 years, 7 months ago (2014-04-28 14:01:56 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 14:01:57 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-04-28 14:01:58 UTC) #4
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 7 months ago (2014-04-28 14:06:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/258933009/1
6 years, 7 months ago (2014-04-28 14:07:21 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 14:17:37 UTC) #7
Message was sent while issue was closed.
Change committed as 266559

Powered by Google App Engine
This is Rietveld 408576698