Issue 258933007: Error stack getter should not overwrite itself with a data property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258933007: Error stack getter should not overwrite itself with a data property. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Error stack getter should not overwrite itself with a data property. R=ulan@chromium.org BUG=v8:3294 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=21016

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -28 lines)			Patch
	M	src/messages.js	View		4 chunks	+27 lines, -24 lines	1 comment	Download
	A +	test/mjsunit/regress/regress-3294.js	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/258933007/diff/1/src/messages.js File src/messages.js (right): https://codereview.chromium.org/258933007/diff/1/src/messages.js#newcode1175 src/messages.js:1175: // property (on the holder). The comment is ...

6 years, 7 months ago (2014-04-28 12:01:26 UTC) #2

Yang

6 years, 7 months ago (2014-04-28 12:14:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21016 (presubmit successful).

Expand Messages | Collapse Messages