LayoutTests/fast/forms/label/label-selection.html - Issue 258933006: Fix selection of label having control element.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/label/label-selection.html

Issue 258933006: Fix selection of label having control element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Layout test updated Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <script src="../../../resources/js-test.js"></script>
	keishi 2014/05/02 07:52:03 I think form tests generally don't indent after <h I think form tests generally don't indent after <html>, <body>, <script> deepak.sa 2014/05/02 08:28:27 Done. Show quoted text On 2014/05/02 07:52:03, keishi1 wrote: > I think form tests generally don't indent after <html>, <body>, <script> Done.
	4 <body>

	5 <label id="labelWithInput" for="inputText">Some Text associated with input</ label>
	keishi 2014/05/02 07:52:03 Ditto. Ditto. deepak.sa 2014/05/02 08:28:27 Done. Show quoted text On 2014/05/02 07:52:03, keishi1 wrote: > Ditto. Done.
	6 <input id="inputText" type='text'>

	7 </body>

	8

	9 <script>

	10 description("Test the selection of label associated with input.");

	11 if (window.testRunner) {

	12 testRunner.dumpAsText();

	13 var labelElement = document.getElementById("labelWithInput");

	14

	15 testWithDoubleClick(labelElement);

	16 shouldBeEqualToString('window.getSelection().toString()', "Some");
	keishi 2014/05/02 07:52:03 We shouldn't mix single and double quotes. We try We shouldn't mix single and double quotes. We try to use single quotes in JavaScript deepak.sa 2014/05/02 08:28:27 Done. Show quoted text On 2014/05/02 07:52:03, keishi1 wrote: > We shouldn't mix single and double quotes. We try to use single quotes in > JavaScript Done.
	17

	18 labelElement.style.display = "none";

	19 }
	keishi 2014/05/02 07:52:03 Indentation is messed up. Indentation is messed up. deepak.sa 2014/05/02 08:28:27 Done. Show quoted text On 2014/05/02 07:52:03, keishi1 wrote: > Indentation is messed up. Done.
	20

	21 function testWithDoubleClick(element)

	22 {
	keishi 2014/05/02 07:52:03 I think form tests generally don't break before cu I think form tests generally don't break before curly braces deepak.sa 2014/05/02 08:28:27 Sorry, but i am not able to follow the above comme Show quoted text On 2014/05/02 07:52:03, keishi1 wrote: > I think form tests generally don't break before curly braces Sorry, but i am not able to follow the above comment. Can you elaborate? Thanks! keishi 2014/05/02 08:48:34 I was talking about the line break between line 21 Show quoted text On 2014/05/02 08:28:27, deepak.sa wrote: > On 2014/05/02 07:52:03, keishi1 wrote: > > I think form tests generally don't break before curly braces > > Sorry, but i am not able to follow the above comment. Can you elaborate? > Thanks! I was talking about the line break between line 21 and 22.
	23 eventSender.mouseMoveTo(element.offsetLeft, element.offsetTop);

	24 eventSender.mouseDown();

	25 eventSender.mouseUp();

	26 eventSender.mouseDown();

	27 eventSender.mouseUp();

	28 }

	29 </script>

	30 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/label/label-selection-expected.txt » ('j') | no next file with comments »