Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: ios/web/web_state/ui/crw_web_controller_container_view.mm

Issue 2589213002: Add CRWNativeContent willBeDismissed. (Closed)
Patch Set: in container view Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller_container_view.mm
diff --git a/ios/web/web_state/ui/crw_web_controller_container_view.mm b/ios/web/web_state/ui/crw_web_controller_container_view.mm
index 25e31bdead7566ca9822665fe69d06cb203c3764..fd97cd984375e8104b9bd89905247095968dee16 100644
--- a/ios/web/web_state/ui/crw_web_controller_container_view.mm
+++ b/ios/web/web_state/ui/crw_web_controller_container_view.mm
@@ -170,6 +170,9 @@
}
- (void)setNativeController:(id<CRWNativeContent>)nativeController {
+ if ([_nativeController respondsToSelector:@selector(willBeDismissed)]) {
Eugene But (OOO till 7-30) 2016/12/21 15:26:35 Should this be moved inside |(![_nativeController
Olivier 2016/12/21 15:41:11 The logic is to call in any navigation. If the nat
Olivier 2016/12/21 15:51:36 Done.
+ [_nativeController willBeDismissed];
+ }
if (![_nativeController isEqual:nativeController]) {
base::WeakNSProtocol<id> oldController(_nativeController);
[[oldController view] removeFromSuperview];

Powered by Google App Engine
This is Rietveld 408576698