Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 25892005: Remove some unused scripts from Tools/Scripts/ (Closed)

Created:
7 years, 2 months ago by Julien - ping for review
Modified:
7 years, 2 months ago
Reviewers:
Dirk Pranke, eseidel
CC:
blink-reviews, abarth-chromium, Dirk Pranke
Visibility:
Public.

Description

Remove some unused scripts from Tools/Scripts/ - bisect-builds was used to bisect using WebKit Mac nightlies. - check-for-inappropriate-files-in-framework, check-for-inappropriate-macros-in-external-headers and check-for-inappropriate-objc-class-names were used to check that Mac WebKit doesn't contain bad files, names or macros. - convert-test-expectations was used when transitioning to TestExpectations. - execAppWithEnv was used to work around a perl bug when running run-webkit-tests in 2009. See https://webkit.org/b/25101. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -763 lines) Patch
D Tools/Scripts/bisect-builds View 1 chunk +0 lines, -445 lines 0 comments Download
D Tools/Scripts/check-for-inappropriate-files-in-framework View 1 chunk +0 lines, -70 lines 0 comments Download
D Tools/Scripts/check-for-inappropriate-macros-in-external-headers View 1 chunk +0 lines, -77 lines 0 comments Download
D Tools/Scripts/check-for-inappropriate-objc-class-names View 1 chunk +0 lines, -114 lines 0 comments Download
D Tools/Scripts/convert-test-expectations View 1 chunk +0 lines, -19 lines 0 comments Download
D Tools/Scripts/execAppWithEnv View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Julien - ping for review
Stabbed some of Eric's to-be-killed scripts. @dpranke: Scream if Tools/Scripts/convert-test-expectations is actually in use :)
7 years, 2 months ago (2013-10-04 01:32:01 UTC) #1
Dirk Pranke
lgtm. convert-test-expectations is no longer needed, and I've never seen anyone use any of the ...
7 years, 2 months ago (2013-10-04 01:46:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/25892005/1
7 years, 2 months ago (2013-10-04 16:18:21 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 17:47:46 UTC) #4
Message was sent while issue was closed.
Change committed as 158949

Powered by Google App Engine
This is Rietveld 408576698