Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2589183002: Move CodegenEnqueuer.generatedCode to JavaScriptBackend. (Closed)

Created:
4 years ago by Johnni Winther
Modified:
4 years ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move CodegenEnqueuer.generatedCode to JavaScriptBackend. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f68ba35fe591062f49c82c97250ea666c096c227

Patch Set 1 #

Patch Set 2 : dartfmt #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -43 lines) Patch
M pkg/compiler/lib/src/enqueue.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 chunks +8 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 1 11 chunks +20 lines, -28 lines 2 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years ago (2016-12-20 12:15:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2589183002/diff/20001/pkg/compiler/lib/src/js_backend/enqueuer.dart File pkg/compiler/lib/src/js_backend/enqueuer.dart (right): https://codereview.chromium.org/2589183002/diff/20001/pkg/compiler/lib/src/js_backend/enqueuer.dart#newcode111 pkg/compiler/lib/src/js_backend/enqueuer.dart:111: void applyImpact(WorldImpact worldImpact, {var impactSource}) { var => ...
4 years ago (2016-12-20 19:26:34 UTC) #3
Johnni Winther
https://codereview.chromium.org/2589183002/diff/20001/pkg/compiler/lib/src/js_backend/enqueuer.dart File pkg/compiler/lib/src/js_backend/enqueuer.dart (right): https://codereview.chromium.org/2589183002/diff/20001/pkg/compiler/lib/src/js_backend/enqueuer.dart#newcode111 pkg/compiler/lib/src/js_backend/enqueuer.dart:111: void applyImpact(WorldImpact worldImpact, {var impactSource}) { On 2016/12/20 19:26:34, ...
4 years ago (2016-12-21 09:43:40 UTC) #4
Johnni Winther
4 years ago (2016-12-21 09:49:28 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f68ba35fe591062f49c82c97250ea666c096c227 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698