Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)
Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
index bdd2be239203df2db2d197af05b7a5dac3298148..06b3a51ff8dc594330095f2bb62ad9931c9ad47d 100644
--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp
@@ -285,15 +285,16 @@ bool WebPagePopupImpl::initializePage() {
m_page = Page::create(pageClients);
m_page->settings().setScriptEnabled(true);
m_page->settings().setAllowScriptsToCloseWindows(true);
- m_page->settings().setDeviceSupportsTouch(mainSettings.deviceSupportsTouch());
- m_page->settings().setMinimumFontSize(mainSettings.minimumFontSize());
+ m_page->settings().setDeviceSupportsTouch(
+ mainSettings.getDeviceSupportsTouch());
+ m_page->settings().setMinimumFontSize(mainSettings.getMinimumFontSize());
m_page->settings().setMinimumLogicalFontSize(
- mainSettings.minimumLogicalFontSize());
+ mainSettings.getMinimumLogicalFontSize());
// FIXME: Should we support enabling a11y while a popup is shown?
m_page->settings().setAccessibilityEnabled(
- mainSettings.accessibilityEnabled());
+ mainSettings.getAccessibilityEnabled());
m_page->settings().setScrollAnimatorEnabled(
- mainSettings.scrollAnimatorEnabled());
+ mainSettings.getScrollAnimatorEnabled());
provideContextFeaturesTo(*m_page, WTF::makeUnique<PagePopupFeaturesClient>());
DEFINE_STATIC_LOCAL(FrameLoaderClient, emptyFrameLoaderClient,
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/Source/web/WebSettingsImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698