third_party/WebKit/Source/web/ContextMenuClientImpl.cpp - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

index 71adf55e45e4a7473b4b8998b547c13005147e4f..2c18919bb22f9421733356244ef21101e53040a2 100644

--- a/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ContextMenuClientImpl.cpp

@@ -138,7 +138,7 @@ static String selectMisspellingAsync(LocalFrame* selectedFrame,

bool ContextMenuClientImpl::shouldShowContextMenuFromTouch(

const WebContextMenuData& data) {

- return m_webView->page()->settings().alwaysShowContextMenuOnTouch() ||

+ return m_webView->page()->settings().getAlwaysShowContextMenuOnTouch() ||

!data.linkURL.isEmpty() ||

data.mediaType == WebContextMenuData::MediaTypeImage ||

data.mediaType == WebContextMenuData::MediaTypeVideo ||