third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/Presentation.cpp ('k') | third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

index b846410eb5486a690dd33e426bf2cc23a1d54927..5a0f020e992218c50ae6f685d64835b73d864cef 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

@@ -106,7 +106,7 @@ bool PresentationRequest::hasPendingActivity() const {

ScriptPromise PresentationRequest::start(ScriptState* scriptState) {

Settings* contextSettings = settings(getExecutionContext());

bool isUserGestureRequired =

- !contextSettings || contextSettings->presentationRequiresUserGesture();

+ !contextSettings || contextSettings->getPresentationRequiresUserGesture();

if (isUserGestureRequired && !UserGestureIndicator::utilizeUserGesture())

return ScriptPromise::rejectWithDOMException(