third_party/WebKit/Source/core/testing/InternalSettings.cpp - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/InternalSettings.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerSettings.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/InternalSettings.cpp

diff --git a/third_party/WebKit/Source/core/testing/InternalSettings.cpp b/third_party/WebKit/Source/core/testing/InternalSettings.cpp

index bcd8a8f7cfdcf57c88bbd93443494d0f9c18474e..4e7ddbf4f474587f5cd24918e6467daff98cd6a8 100644

--- a/third_party/WebKit/Source/core/testing/InternalSettings.cpp

+++ b/third_party/WebKit/Source/core/testing/InternalSettings.cpp

@@ -64,23 +64,23 @@ InternalSettings::Backup::Backup(Settings* settings)

RuntimeEnabledFeatures::cssStickyPositionEnabled()),

m_originalOverlayScrollbarsEnabled(

RuntimeEnabledFeatures::overlayScrollbarsEnabled()),

- m_originalEditingBehavior(settings->editingBehaviorType()),

+ m_originalEditingBehavior(settings->getEditingBehaviorType()),

m_originalTextAutosizingEnabled(settings->textAutosizingEnabled()),

m_originalTextAutosizingWindowSizeOverride(

settings->textAutosizingWindowSizeOverride()),

m_originalAccessibilityFontScaleFactor(

- settings->accessibilityFontScaleFactor()),

- m_originalMediaTypeOverride(settings->mediaTypeOverride()),

- m_originalDisplayModeOverride(settings->displayModeOverride()),

+ settings->getAccessibilityFontScaleFactor()),

+ m_originalMediaTypeOverride(settings->getMediaTypeOverride()),

+ m_originalDisplayModeOverride(settings->getDisplayModeOverride()),

m_originalMockScrollbarsEnabled(settings->mockScrollbarsEnabled()),

m_originalMockGestureTapHighlightsEnabled(

- settings->mockGestureTapHighlightsEnabled()),

+ settings->getMockGestureTapHighlightsEnabled()),

m_langAttributeAwareFormControlUIEnabled(

RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled()),

- m_imagesEnabled(settings->imagesEnabled()),

- m_defaultVideoPosterURL(settings->defaultVideoPosterURL()),

- m_originalLayerSquashingEnabled(settings->layerSquashingEnabled()),

- m_originalImageAnimationPolicy(settings->imageAnimationPolicy()),

+ m_imagesEnabled(settings->getImagesEnabled()),

+ m_defaultVideoPosterURL(settings->getDefaultVideoPosterURL()),

+ m_originalLayerSquashingEnabled(settings->getLayerSquashingEnabled()),

+ m_originalImageAnimationPolicy(settings->getImageAnimationPolicy()),

m_originalScrollTopLeftInteropEnabled(

RuntimeEnabledFeatures::scrollTopLeftInteropEnabled()),

m_originalCompositorWorkerEnabled(