third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 84c469ea2d1e8e361998d35c00430d83a8d4554e..3ce520e29d11f9218b229563efac151e4b206684 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -377,7 +377,7 @@ void DOMWindow::close(ExecutionContext* context) {

Settings* settings = frame()->settings();

bool allowScriptsToCloseWindows =

- settings && settings->allowScriptsToCloseWindows();

+ settings && settings->getAllowScriptsToCloseWindows();

if (!page->openedByDOM() && frame()->client()->backForwardLength() > 1 &&

!allowScriptsToCloseWindows) {