third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl - Issue 2589143003: Add 'get' prefix for Settings.in generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)

Patch Set: Capitalize the prefix. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/InternalSettingsGenerated.cpp.tmpl ('k') | third_party/WebKit/Source/core/css/CSSImageSetValue.cpp » ('j') | third_party/WebKit/Source/core/css/CSSImageSetValue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

index b97ad0c742f24eb88419745a3823c7d18a818e3b..d49387c97232ab1aa11f2bfd956d5d17c8714e1e 100644

--- a/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl

@@ -6,7 +6,7 @@

#define SETTINGS_GETTERS_AND_SETTERS \

{% for setting in settings %}

- {{setting.type|to_passing_type}} {{setting.name}}() const { return m_{{setting.name}}; } \

+ {{setting.type|to_passing_type}} Get{{setting.name|upper_first}}() const { return m_{{setting.name}}; } \

void set{{setting.name|upper_first}}({{setting.type|to_passing_type}} {{setting.name}}); \

{% endfor %}

void setFromStrings(const String& name, const String& value);