Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: third_party/WebKit/Source/core/events/EventDispatcher.cpp

Issue 2589143003: Add 'get' prefix for Settings.in generated code. (Closed)
Patch Set: Only get prefix and no capitalization. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
6 * rights reserved. 6 * rights reserved.
7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 7 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2011 Google Inc. All rights reserved. 10 * Copyright (C) 2011 Google Inc. All rights reserved.
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 m_event->isTrusted() || isClick; 280 m_event->isTrusted() || isClick;
281 281
282 // For Android WebView (distinguished by wideViewportQuirkEnabled) 282 // For Android WebView (distinguished by wideViewportQuirkEnabled)
283 // enable untrusted events for mouse down on select elements because 283 // enable untrusted events for mouse down on select elements because
284 // fastclick.js seems to generate these. crbug.com/642698 284 // fastclick.js seems to generate these. crbug.com/642698
285 // TODO(dtapuska): Change this to a target SDK quirk crbug.com/643705 285 // TODO(dtapuska): Change this to a target SDK quirk crbug.com/643705
286 if (!isTrustedOrClick && m_event->isMouseEvent() && 286 if (!isTrustedOrClick && m_event->isMouseEvent() &&
287 m_event->type() == EventTypeNames::mousedown && 287 m_event->type() == EventTypeNames::mousedown &&
288 isHTMLSelectElement(*m_node)) { 288 isHTMLSelectElement(*m_node)) {
289 if (Settings* settings = m_node->document().settings()) { 289 if (Settings* settings = m_node->document().settings()) {
290 isTrustedOrClick = settings->wideViewportQuirkEnabled(); 290 isTrustedOrClick = settings->getWideViewportQuirkEnabled();
291 } 291 }
292 } 292 }
293 293
294 // Call default event handlers. While the DOM does have a concept of 294 // Call default event handlers. While the DOM does have a concept of
295 // preventing default handling, the detail of which handlers are called is an 295 // preventing default handling, the detail of which handlers are called is an
296 // internal implementation detail and not part of the DOM. 296 // internal implementation detail and not part of the DOM.
297 if (!m_event->defaultPrevented() && !m_event->defaultHandled() && 297 if (!m_event->defaultPrevented() && !m_event->defaultHandled() &&
298 isTrustedOrClick) { 298 isTrustedOrClick) {
299 // Non-bubbling events call only one default event handler, the one for the 299 // Non-bubbling events call only one default event handler, the one for the
300 // target. 300 // target.
(...skipping 19 matching lines...) Expand all
320 // events to open select boxes. 320 // events to open select boxes.
321 if (!m_event->isTrusted() && m_event->isMouseEvent() && 321 if (!m_event->isTrusted() && m_event->isMouseEvent() &&
322 m_event->type() == EventTypeNames::mousedown && 322 m_event->type() == EventTypeNames::mousedown &&
323 isHTMLSelectElement(*m_node)) { 323 isHTMLSelectElement(*m_node)) {
324 UseCounter::count(m_node->document(), 324 UseCounter::count(m_node->document(),
325 UseCounter::UntrustedMouseDownEventDispatchedToSelect); 325 UseCounter::UntrustedMouseDownEventDispatchedToSelect);
326 } 326 }
327 } 327 }
328 328
329 } // namespace blink 329 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698