[api] add API for Promise status and result.

src/api.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/api.h"
 
 #include <string.h>  // For memcpy, strlen.
 #ifdef V8_USE_ADDRESS_SANITIZER
 #include <sanitizer/asan_interface.h>
 #endif  // V8_USE_ADDRESS_SANITIZER
@@ skipping 7271 matching lines @@
   i::Isolate* isolate = promise->GetIsolate();
   LOG_API(isolate, Promise, HasRejectHandler);
   ENTER_V8(isolate);
   if (promise->IsJSPromise()) {
     i::Handle<i::JSPromise> js_promise = i::Handle<i::JSPromise>::cast(promise);
     return js_promise->has_handler();
   }
   return false;
 }
 
+MaybeLocal<Value> Promise::Result() {
+  i::Handle<i::JSReceiver> promise = Utils::OpenHandle(this);
+  i::Isolate* isolate = promise->GetIsolate();
+  LOG_API(isolate, Promise, Result);
+  ENTER_V8(isolate);

[jochen (gone - plz use gerrit), 2016/12/20 07:49:52]

this method (and Status) don't execute script, so we don't need to enter here

[Yang, 2016/12/20 11:38:27]

Done.

+  Utils::ApiCheck(promise->IsJSPromise(), "v8_Promise_Result", "Not a Promise");

[jochen (gone - plz use gerrit), 2016/12/20 07:49:52]

that check should never trigger, so I'd suggest to remove it

[Yang, 2016/12/20 11:38:27]

Done.

+  i::Handle<i::JSPromise> js_promise = i::Handle<i::JSPromise>::cast(promise);
+  if (js_promise->status() != i::kPromisePending) {
+    i::Handle<i::Object> result(js_promise->result(), isolate);
+    return Utils::ToLocal(result);
+  }
+  return MaybeLocal<Value>();

[jochen (gone - plz use gerrit), 2016/12/20 07:49:52]

APIs should return empty handles iff an exception was thrown.

[Yang, 2016/12/20 11:38:27]

Done. Now requiring status not to be pending guarded by ApiCheck.

+}
+
+Promise::PromiseStatus Promise::Status() {
+  i::Handle<i::JSReceiver> promise = Utils::OpenHandle(this);
+  i::Isolate* isolate = promise->GetIsolate();
+  LOG_API(isolate, Promise, Status);
+  ENTER_V8(isolate);
+  Utils::ApiCheck(promise->IsJSPromise(), "v8_Promise_Status", "Not a Promise");
+  i::Handle<i::JSPromise> js_promise = i::Handle<i::JSPromise>::cast(promise);
+  STATIC_ASSERT(static_cast<int>(i::kPromisePending) == kPending);

[jochen (gone - plz use gerrit), 2016/12/20 07:49:52]

an alternative approach was to use the external enum internally

[Yang, 2016/12/20 11:38:27]

Done.

+  STATIC_ASSERT(static_cast<int>(i::kPromiseFulfilled) == kFulfilled);
+  STATIC_ASSERT(static_cast<int>(i::kPromiseRejected) == kRejected);
+  return static_cast<PromiseStatus>(js_promise->status());
+}
 
 Local<Object> Proxy::GetTarget() {
   i::Handle<i::JSProxy> self = Utils::OpenHandle(this);
   i::Handle<i::JSReceiver> target(self->target());
   return Utils::ToLocal(target);
 }
 
 
 Local<Value> Proxy::GetHandler() {
   i::Handle<i::JSProxy> self = Utils::OpenHandle(this);
@@ skipping 2602 matching lines @@
   Address callback_address =
       reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
   VMState<EXTERNAL> state(isolate);
   ExternalCallbackScope call_scope(isolate, callback_address);
   callback(info);
 }
 
 
 }  // namespace internal
 }  // namespace v8