Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2589103002: Disable TabCaptureApiTest.FullscreenEvents test (Closed)

Created:
4 years ago by yoichio
Modified:
4 years ago
Reviewers:
miu
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, extensions-reviews_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable TabCaptureApiTest.FullscreenEvents test TBR=OWNER BUG=675851 Committed: https://chromium.googlesource.com/chromium/src/+/996b83c7e4a2ab246ba1b4e5f51dc11cd610f9c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/996b83c7e4a2ab246ba1b4e5f51dc11cd610f9c4 Cr-Commit-Position: refs/heads/master@{#439729}
4 years ago (2016-12-20 06:40:21 UTC) #4
yoichio
Committed patchset #1 (id:1) manually as 996b83c7e4a2ab246ba1b4e5f51dc11cd610f9c4 (presubmit successful).
4 years ago (2016-12-20 06:42:02 UTC) #6
miu
4 years ago (2016-12-21 02:59:39 UTC) #8
Message was sent while issue was closed. 
not lgtm

You shouldn't disable the test for all platforms just because one platform
(Linux) was flaky. Please fix this immediately.

Powered by Google App Engine
This is Rietveld 408576698