Issue 25890007: [CSS Regions] Layout Test for selecting text in 2 regions

Issue 25890007: [CSS Regions] Layout Test for selecting text in 2 regions (Closed)

Created:
7 years, 2 months ago by Manuel Rego

Modified:
7 years, 2 months ago

Reviewers:
ojan, eseidel, Julien - ping for review

CC:
blink-reviews, chromiumbugtracker_adobe.com

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

[CSS Regions] Layout Test for selecting text in 2 regions Patch already landed in WebKit. See http://trac.webkit.org/changeset/156857 and http://trac.webkit.org/changeset/156914 Add new reftests for selecting text in 2 regions. It compares the behavior (highlighted text and selected content) in regions and absolute positions. Different layout tests for other writing modes are provided too. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158985

Patch Set 1 #

Total comments: 1

Patch Set 2 : Using Vertical instead of Vert for both JavaScript method and CSS classes. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+444 lines, -0 lines)			Patch
M	LayoutTests/fast/regions/resources/helper.js	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	LayoutTests/fast/regions/resources/region-style.css	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions.html	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-expected.html	View		1 chunk	+55 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html	View		1 chunk	+40 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html	View		1 chunk	+59 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr.html	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl.html	View	1	1 chunk	+40 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/25890007/diff/1/LayoutTests/fast/regions/resources/helper.js File LayoutTests/fast/regions/resources/helper.js (right): https://codereview.chromium.org/25890007/diff/1/LayoutTests/fast/regions/resources/helper.js#newcode227 LayoutTests/fast/regions/resources/helper.js:227: function selectContentByIdsVert(fromId, toId) { Blink code prefers avoiding ...

7 years, 2 months ago (2013-10-04 22:26:05 UTC) #2

Manuel Rego

On 2013/10/04 22:26:05, ojan wrote: > lgtm Thanks for the review. > https://codereview.chromium.org/25890007/diff/1/LayoutTests/fast/regions/resources/helper.js#newcode227 > LayoutTests/fast/regions/resources/helper.js:227: ...

7 years, 2 months ago (2013-10-04 22:39:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/25890007/6001

7 years, 2 months ago (2013-10-05 08:47:26 UTC) #4

Message was sent while issue was closed.

Change committed as 158985

Expand Messages | Collapse Messages