chrome/chrome_syzygy.gypi - Issue 25890006: Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_syzygy.gypi

Issue 25890006: Copy asan_rtl.* and agent_logger.exe to the syzygy directory for the ASan builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_syzygy.gypi

diff --git a/chrome/chrome_syzygy.gypi b/chrome/chrome_syzygy.gypi

index 50a05c34e660c0104f3918a99842b0978f22657f..b3884781bf5d40213313f34be3c9df0f9919ae28 100644

--- a/chrome/chrome_syzygy.gypi

+++ b/chrome/chrome_syzygy.gypi

@@ -50,16 +50,20 @@

'action_name': 'Instrument Chrome with SyzyAsan',

'msvs_cygwin_shell': 0,

'inputs': [

- '<(PRODUCT_DIR)/<(dll_name).dll',

'<(DEPTH)/chrome/tools/build/win/win-syzyasan-filter.txt',

+ '<(dest_dir)/agent_logger.exe',

+ '<(dest_dir)/syzyasan_rtl.dll',

+ '<(dest_dir)/syzyasan_rtl.dll.pdb',

+ '<(PRODUCT_DIR)/<(dll_name).dll',

'outputs': [

'<(dest_dir)/<(dll_name).dll',

'<(dest_dir)/<(dll_name).dll.pdb',

- '<(dest_dir)/syzyasan_rtl.dll',

- '<(dest_dir)/syzyasan_rtl.dll.pdb',

'<(dest_dir)/win-syzyasan-filter-<(dll_name).txt.json',

+ 'dependencies': [

+ '<(DEPTH)/chrome/chrome_syzygy.gyp:copy_syzyasan_binaries',

Roger McFarlane (Chromium) 2013/10/04 20:57:30 this gypi is included just before this target gets

Sébastien Marchand 2013/10/07 18:57:49 Done, however I'm not sure that it was the issue,

+ ],

'action': [

'python',

'<(DEPTH)/chrome/tools/build/win/syzygy_instrument.py',

« chrome/chrome_syzygy.gyp ('K') | « chrome/chrome_syzygy.gyp ('k') | chrome/tools/build/win/syzygy_instrument.py » ('j') | no next file with comments »