Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js

Issue 2588963002: Turn on icu_case_mapping by default (Closed)
Patch Set: add fail tests for Lower,UpperCase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | test/webkit/fast/js/string-capitalization-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
diff --git a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
index 154498c91113435056eaafab799d8f6cfda05f79..989cb393113154acd9af58a1019c0977c724be99 100644
--- a/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
+++ b/test/debugger/debug/debug-evaluate-no-side-effect-builtins.js
@@ -46,7 +46,10 @@ function listener(event, exec_state, event_data, data) {
for (f of Object.getOwnPropertyNames(String.prototype)) {
if (typeof String.prototype[f] === "function") {
// Do not expect locale-specific or regexp-related functions to work.
+ // {Lower,Upper}Case (Locale-specific or not) do not work either.
if (f.indexOf("locale") >= 0) continue;
+ if (f.indexOf("Lower") >= 0) continue;
+ if (f.indexOf("Upper") >= 0) continue;
if (f == "normalize") continue;
if (f == "match") continue;
if (f == "search") continue;
@@ -54,6 +57,10 @@ function listener(event, exec_state, event_data, data) {
success("abcd"[f](2), `"abcd".${f}(2);`);
}
}
+ fail("'abCd'.toLowerCase()");
+ fail("'abcd'.toUpperCase()");
+ fail("'abCd'.toLocaleLowerCase()");
+ fail("'abcd'.toLocaleUpperCase()");
fail("'abcd'.match(/a/)");
fail("'abcd'.replace(/a/)");
fail("'abcd'.search(/a/)");
« no previous file with comments | « src/flag-definitions.h ('k') | test/webkit/fast/js/string-capitalization-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698