app_shell: Add support for mouse cursors.

app_shell: Add support for mouse cursors.

Move ImageCursors from ash/wm/ to ui/base/cursors/ and add a
NativeCursorManager implementation for
ShellDesktopController to use.

BUG=364290
TEST=cursor is visible when running app_shell on a Chrome OS
     device and changes after mousing over a link

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266694

[Daniel Erat, 2014-04-25 21:41:50]

scott: please review the move of ImageCursors to ui/
ken/james: apps/shell/browser/
oshima: fyi

[sky, 2014-04-25 22:40:17]

LGTM

[James Cook, 2014-04-25 22:48:00]

LGTM with one question

https://codereview.chromium.org/258893002/diff/40001/apps/shell/browser/shell...
File apps/shell/browser/shell_desktop_controller.cc (right):

https://codereview.chromium.org/258893002/diff/40001/apps/shell/browser/shell...
apps/shell/browser/shell_desktop_controller.cc:89: gfx::NativeCursor new_cursor
= cursor;
Any particular reason for copying the cursor?

[Daniel Erat, 2014-04-25 23:23:25]

https://codereview.chromium.org/258893002/diff/40001/apps/shell/browser/shell...
File apps/shell/browser/shell_desktop_controller.cc (right):

https://codereview.chromium.org/258893002/diff/40001/apps/shell/browser/shell...
apps/shell/browser/shell_desktop_controller.cc:89: gfx::NativeCursor new_cursor
= cursor;
On 2014/04/25 22:48:00, James Cook wrote:
> Any particular reason for copying the cursor?

i must sheepishly admit that i did this because AshNativeCursorManager does it.
since |cursor| is passed by value, though, it doesn't make any sense to me
either. i've removed the copy from both implementations (but will hold off on
committing until i can test this on monday to make sure that there isn't some
reason for it that i'm missing).

[Daniel Erat, 2014-04-28 13:15:12]

https://codereview.chromium.org/258893002/diff/60001/ash/wm/ash_native_cursor...
File ash/wm/ash_native_cursor_manager.cc (left):

https://codereview.chromium.org/258893002/diff/60001/ash/wm/ash_native_cursor...
ash/wm/ash_native_cursor_manager.cc:86: gfx::NativeCursor new_cursor = cursor;
mazda@, just to double-check: i think that you originally added this copy in
https://chromiumcodereview.appspot.com/11412315. is it safe to remove it, as i'm
doing here?

[Daniel Erat, 2014-04-28 15:58:43]

seems to work fine, so i'm checking this in now.

[Daniel Erat, 2014-04-28 15:58:49]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:59:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/258893002/60001

[commit-bot: I haz the power, 2014-04-28 15:59:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 15:59:14]

Failed to apply patch for ash/wm/ash_native_cursor_manager_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ash/wm/ash_native_cursor_manager_unittest.cc
  Hunk #1 FAILED at 9.
  1 out of 1 hunk FAILED -- saving rejects to file
ash/wm/ash_native_cursor_manager_unittest.cc.rej

Patch:       ash/wm/ash_native_cursor_manager_unittest.cc
Index: ash/wm/ash_native_cursor_manager_unittest.cc
diff --git a/ash/wm/ash_native_cursor_manager_unittest.cc
b/ash/wm/ash_native_cursor_manager_unittest.cc
index
5713fe3f02be0e29cc034e6aeb9ed754629daa0f..b33e1d3158272f03209a620ff3631f13e12fa665
100644
--- a/ash/wm/ash_native_cursor_manager_unittest.cc
+++ b/ash/wm/ash_native_cursor_manager_unittest.cc
@@ -9,11 +9,11 @@
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/cursor_manager_test_api.h"
-#include "ash/wm/image_cursors.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/test/test_windows.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_event_dispatcher.h"
+#include "ui/base/cursor/image_cursors.h"
 #include "ui/gfx/screen.h"
 
 #if defined(OS_WIN)

[Daniel Erat, 2014-04-28 16:56:33]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-04-28 16:56:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/258893002/80001

[commit-bot: I haz the power, 2014-04-28 17:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 17:04:11]

Try jobs failed on following builders:
  tryserver.chromium on android_clang_dbg

[Daniel Erat, 2014-04-28 18:21:16]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-04-28 18:25:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/258893002/100001

[commit-bot: I haz the power, 2014-04-28 20:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:03:19]

Try jobs failed on following builders:
  tryserver.chromium on ios_rel_device

[Daniel Erat, 2014-04-28 20:42:10]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2014-04-28 20:42:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/258893002/100001

[commit-bot: I haz the power, 2014-04-28 23:46:24]

Change committed as 266694