Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: components/metrics/persisted_logs_metrics.h

Issue 2588873002: Delegate PersistedLogs metrics recording (Closed)
Patch Set: Histogram description Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
rkaplow 2016/12/19 21:44:33 nit 2016
Steven Holte 2016/12/19 21:53:12 Done.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_METRICS_PERSISTED_LOGS_METRICS_H_
6 #define COMPONENTS_METRICS_PERSISTED_LOGS_METRICS_H_
7
8 #include "base/macros.h"
9 #include "components/metrics/persisted_logs.h"
10
11 namespace metrics {
12
13 // Maintains a list of unsent logs that are written and restored from disk.
rkaplow 2016/12/19 21:44:33 fix comment
Steven Holte 2016/12/19 21:53:12 Done.
rkaplow 2016/12/19 21:55:09 Did the impl but missed the base here
14 class PersistedLogsMetrics {
15 public:
16 PersistedLogsMetrics() {}
17 ~PersistedLogsMetrics() {}
18
19 virtual PersistedLogs::LogReadStatus RecordLogReadStatus(
20 PersistedLogs::LogReadStatus status) = 0;
21
22 virtual void RecordCompressionRatio(
23 size_t compressed_size, size_t original_size) {}
24
25 virtual void RecordDroppedLogSize(size_t size) {}
26
27 virtual void RecordDroppedLogsNum(int dropped_logs_num) {}
28
29 private:
30 DISALLOW_COPY_AND_ASSIGN(PersistedLogsMetrics);
31 };
32
33 } // namespace metrics
34
35 #endif // COMPONENTS_METRICS_PERSISTED_LOGS_METRICS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698