third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py - Issue 2588863002: Make MockExecutive behave more like MockExecutive2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

Issue 2588863002: Make MockExecutive behave more like MockExecutive2. (Closed)

Patch Set: Rebased Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

index 238fff70b15780ed236f36a2eb2e7d5dfdc5f022..7959bdeacd6f37fd5e015c623c0370c0a1599401 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

@@ -40,11 +40,11 @@ from webkitpy.layout_tests.port.test import add_unit_tests_to_mock_filesystem

class MockHost(MockSystemHost):

- def __init__(self, log_executive=False, executive_throws_when_run=None,

+ def __init__(self, log_executive=False,

initialize_scm_by_default=True, web=None, scm=None, os_name=None, os_version=None,

time_return_val=123):

jeffcarp 2016/12/22 22:48:46 Do you want to re-shuffle the indentation here? (n

- MockSystemHost.__init__(self, log_executive, executive_throws_when_run, os_name=os_name,

+ MockSystemHost.__init__(self, log_executive, os_name=os_name,

os_version=os_version, time_return_val=time_return_val)

add_unit_tests_to_mock_filesystem(self.filesystem)

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py » ('j') | no next file with comments »