Make MockExecutive behave more like MockExecutive2.

third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
index 187890bfa7b8ea9bba9e538e82921e1cd86f3aef..ba6d4bf3beeefc9729d44d33f9f794f94d8370b7 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android_unittest.py
@@ -93,6 +93,8 @@ class AndroidPortTest(port_testcase.PortTestCase):
     def test_check_build(self):
         host = MockSystemHost()
         port = self.make_port(host=host, options=optparse.Values({'child_processes': 1}))
+        # Checking the devices is not tested in this unit test.
+        port._check_devices = lambda _: None

[qyearsley, 2016/12/19 22:49:29]

The reason why this is added:

With the previous version of MockExecutive, _check_devices would never be called
because in AndroidPort.check_build, it would call Port.check_build which would
return something truthy.

(With this change to MockExecutive, MockExecutive.run_command will return 0 by
default if return_exit_code is given, whereas previously it would return a
non-empty string.)

Anyway, I don't believe we necessarily want to test _check_devices in this unit
test, since the real _check_devices method depends on interacting with external
devices.

See:
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

         host.filesystem.exists = lambda p: True
         port.check_build(needs_http=True, printer=port_testcase.FakePrinter())