Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py

Issue 2588863002: Make MockExecutive behave more like MockExecutive2. (Closed)
Patch Set: Reformat args lists for MockHost, MockSystemHost. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2011 Google Inc. All rights reserved. 1 # Copyright (C) 2011 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 22 matching lines...) Expand all
33 from webkitpy.common.system.system_host_mock import MockSystemHost 33 from webkitpy.common.system.system_host_mock import MockSystemHost
34 34
35 # New-style ports need to move down into webkitpy.common. 35 # New-style ports need to move down into webkitpy.common.
36 from webkitpy.layout_tests.builder_list import BuilderList 36 from webkitpy.layout_tests.builder_list import BuilderList
37 from webkitpy.layout_tests.port.factory import PortFactory 37 from webkitpy.layout_tests.port.factory import PortFactory
38 from webkitpy.layout_tests.port.test import add_unit_tests_to_mock_filesystem 38 from webkitpy.layout_tests.port.test import add_unit_tests_to_mock_filesystem
39 39
40 40
41 class MockHost(MockSystemHost): 41 class MockHost(MockSystemHost):
42 42
43 def __init__(self, log_executive=False, executive_throws_when_run=None, 43 def __init__(self,
44 initialize_scm_by_default=True, web=None, scm=None, os_name=Non e, os_version=None, 44 log_executive=False,
45 initialize_scm_by_default=True,
46 web=None,
47 scm=None,
48 os_name=None,
49 os_version=None,
45 time_return_val=123): 50 time_return_val=123):
46 51 super(MockHost, self).__init__(
47 MockSystemHost.__init__(self, log_executive, executive_throws_when_run, os_name=os_name, 52 log_executive=log_executive,
48 os_version=os_version, time_return_val=time_retu rn_val) 53 os_name=os_name,
54 os_version=os_version,
55 time_return_val=time_return_val)
49 56
50 add_unit_tests_to_mock_filesystem(self.filesystem) 57 add_unit_tests_to_mock_filesystem(self.filesystem)
51 self.web = web or MockWeb() 58 self.web = web or MockWeb()
52 59
53 self._scm = scm 60 self._scm = scm
54 # FIXME: we should never initialize the SCM by default, since the real 61 # FIXME: we should never initialize the SCM by default, since the real
55 # object doesn't either. This has caused at least one bug (see bug 89498 ). 62 # object doesn't either. This has caused at least one bug (see bug 89498 ).
56 if initialize_scm_by_default: 63 if initialize_scm_by_default:
57 self.initialize_scm() 64 self.initialize_scm()
58 self.buildbot = MockBuildBot() 65 self.buildbot = MockBuildBot()
(...skipping 11 matching lines...) Expand all
70 # Making the checkout_root exist in the mock filesystem makes that chdir not raise. 77 # Making the checkout_root exist in the mock filesystem makes that chdir not raise.
71 self.filesystem.maybe_make_directory(self._scm.checkout_root) 78 self.filesystem.maybe_make_directory(self._scm.checkout_root)
72 79
73 def scm(self): 80 def scm(self):
74 return self._scm 81 return self._scm
75 82
76 def scm_for_path(self, path): 83 def scm_for_path(self, path):
77 # FIXME: consider supporting more than one SCM so that we can do more co mprehensive testing. 84 # FIXME: consider supporting more than one SCM so that we can do more co mprehensive testing.
78 self.initialize_scm() 85 self.initialize_scm()
79 return self._scm 86 return self._scm
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698