third_party/WebKit/Source/devtools/scripts/README.md - Issue 2588843002: DevTools: speed up closure dependency checking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/scripts/README.md

Issue 2588843002: DevTools: speed up closure dependency checking (Closed)

Patch Set: update BUILD.gn Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/gonzales/module.json ('K') | « third_party/WebKit/Source/devtools/front_end/gonzales/module.json ('k') | third_party/WebKit/Source/devtools/scripts/build/modular_build.py » ('j') | third_party/WebKit/Source/devtools/scripts/closure/closure_runner/src/org/chromium/devtools/compiler/Runner.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/scripts/README.md

diff --git a/third_party/WebKit/Source/devtools/scripts/README.md b/third_party/WebKit/Source/devtools/scripts/README.md

index 3f4a28329e878ebbc77c821b8034ebc2ecd73ae4..17c3b3add015c027bf79dbf408225547d8eaf9da 100644

--- a/third_party/WebKit/Source/devtools/scripts/README.md

+++ b/third_party/WebKit/Source/devtools/scripts/README.md

@@ -32,4 +32,4 @@ The easiest way to run the node.js scripts is to use `npm run` which displays al

## Closure

-DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory. Make sure you use JDK 7 to compile these jars, otherwise they won't run on buildbot. If you compile with JDK 7, anyone with Java 7 or Java 8 should be able to run the jar.

+DevTools manually rolls the closure compiler to ./closure. If you manually roll closure compiler, you will need to re-generate the closure_runner (in ./closure) and jsdoc_validator custom jars using the python scripts in their respective directory.