Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/Runtime.js

Issue 2588843002: DevTools: speed up closure dependency checking (Closed)
Patch Set: re-insert comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 755 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 } 766 }
767 767
768 /** 768 /**
769 * @return {!Promise.<undefined>} 769 * @return {!Promise.<undefined>}
770 */ 770 */
771 _loadScripts() { 771 _loadScripts() {
772 if (!this._descriptor.scripts || !this._descriptor.scripts.length) 772 if (!this._descriptor.scripts || !this._descriptor.scripts.length)
773 return Promise.resolve(); 773 return Promise.resolve();
774 774
775 // the namespace keyword confuses clang-format 775 // the namespace keyword confuses clang-format
776 // NOTE: Update scripts/special_case_namespaces.json if you add a special ca sed namespace
776 // clang-format off 777 // clang-format off
777 // Module namespaces. 778 // Module namespaces.
778 const specialCases = { 779 const specialCases = {
779 'sdk': 'SDK', 780 'sdk': 'SDK',
780 'ui': 'UI', 781 'ui': 'UI',
781 'perf_ui': 'PerfUI', 782 'perf_ui': 'PerfUI',
782 'css_tracker': 'CSSTracker', 783 'css_tracker': 'CSSTracker'
783 'ui_lazy': 'UI',
784 'components_lazy': 'Components'
785 }; 784 };
786 var namespace = specialCases[this._name] || this._name.split('_').map(a => a .substring(0, 1).toUpperCase() + a.substring(1)).join(''); 785 var namespace = specialCases[this._name] || this._name.split('_').map(a => a .substring(0, 1).toUpperCase() + a.substring(1)).join('');
787 self[namespace] = self[namespace] || {}; 786 self[namespace] = self[namespace] || {};
788 // clang-format on 787 // clang-format on
789 return Runtime._loadScriptsPromise(this._descriptor.scripts.map(this._modula rizeURL, this), this._remoteBase()); 788 return Runtime._loadScriptsPromise(this._descriptor.scripts.map(this._modula rizeURL, this), this._remoteBase());
790 } 789 }
791 790
792 /** 791 /**
793 * @param {string} resourceName 792 * @param {string} resourceName
794 */ 793 */
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
1126 send(message) {}, 1125 send(message) {},
1127 1126
1128 /** 1127 /**
1129 * @return {!Promise<boolean>} 1128 * @return {!Promise<boolean>}
1130 */ 1129 */
1131 close() {} 1130 close() {}
1132 }; 1131 };
1133 1132
1134 /** @type {!Runtime} */ 1133 /** @type {!Runtime} */
1135 var runtime; 1134 var runtime;
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/devtools/BUILD.gn ('k') | third_party/WebKit/Source/devtools/scripts/README.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698