DevTools: better hasSelection check to include composed trees

third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

Index: third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
diff --git a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
index 2a2cb03bd15e6062cdea6878f92a303e2264fb94..a94758ec6a80298676cd8b447f08477752f6bc78 100644
--- a/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
+++ b/third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js
@@ -277,6 +277,15 @@ Node.prototype.isComponentSelectionCollapsed = function() {
  * @return {boolean}
  */
 Node.prototype.hasSelection = function() {
+  // FIXME: use contains(node, {includeShadow: true}) when it is fixed for shadow dom.
+  var contents = this.querySelectorAll('content');
+  for (var i = 0; i < contents.length; ++i) {
+    var contentElement = contents[i].getDistributedNodes();

[allada, 2016/12/20 02:15:28]

Wouldnt it be easier to read using something like:
for (var content of contents) {
  if (content.getDistributedNodes().some(element => element.hasSelection()))
    return true;
}

Or even do it all in 1 line using two Array.some() callbacks if it does't over
complicate it.

[luoe, 2016/12/20 02:41:03]

Done.

+    for (var j = 0; j < contentElement.length; ++j) {
+      if (contentElement[j].hasSelection())
+        return true;
+    }
+  }
   if (this.isComponentSelectionCollapsed())
     return false;
   return this.getComponentSelection().containsNode(this, true);