DevTools: better hasSelection check to include composed trees

third_party/WebKit/Source/devtools/front_end/platform/DOMExtension.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 259 matching lines @@
   // FIXME: crbug.com/447523, use selection.isCollapsed when it is fixed for shadow dom.
   var selection = this.getComponentSelection();
   var range = selection && selection.rangeCount ? selection.getRangeAt(0) : null;
   return range ? range.collapsed : true;
 };
 
 /**
  * @return {boolean}
  */
 Node.prototype.hasSelection = function() {
+  // FIXME: use contains(node, {includeShadow: true}) when it is fixed for shadow dom.

[dgozman, 2016/12/22 01:59:33]

TODO(luoe)

[luoe, 2016/12/22 02:03:56]

Done.

+  var contents = this.querySelectorAll('content');
+  for (var content of contents) {
+    if (Array.prototype.some.call(content.getDistributedNodes(), node => node.hasSelection()))

[allada, 2016/12/20 18:41:36]

Why Array.prototype.some.call?

Why not just access it with:
content.getDistributedNodes().some(node => node.hasSelection())

?

[luoe, 2016/12/20 19:23:58]

getDistributedNodes() returns a NodeList, which doesn't have some()
unfortunately.

Alternatively, it could be a forEach that sets hasSelection = hasSelection ||
node.hasSelection(), but I think the current way may be easier to read.

[allada, 2016/12/21 23:28:26]

I see.

+      return true;
+  }
   if (this.isComponentSelectionCollapsed())
     return false;
   return this.getComponentSelection().containsNode(this, true);
 };
 
 /**
  * @return {!Selection}
  */
 Node.prototype.getDeepSelection = function() {
   var activeElement = this.ownerDocument.activeElement;
@@ skipping 528 matching lines @@
   function windowLoaded() {
     window.removeEventListener('DOMContentLoaded', windowLoaded, false);
     callback();
   }
 
   if (document.readyState === 'complete' || document.readyState === 'interactive')
     callback();
   else
     window.addEventListener('DOMContentLoaded', windowLoaded, false);
 }