chrome/test/data/android/webvr_instrumentation/html/test_nfc_fires_onvrdisplayactivate.html - Issue 2588703003: Add WebVR WebVR E2E test capabilities via Android instrumentation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/android/webvr_instrumentation/html/test_nfc_fires_onvrdisplayactivate.html

Issue 2588703003: Add WebVR WebVR E2E test capabilities via Android instrumentation (Closed)

Patch Set: Simplify Javascript code slightly Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java ('k') | chrome/test/data/android/webvr_instrumentation/html/test_pose_data_unfocused_tab.html » ('j') | chrome/test/data/android/webvr_instrumentation/html/test_pose_data_unfocused_tab.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <!--

	3 Tests that scanning the Daydream View NFC tag on supported devices fires the

	4 ondisplayactivate event

	5 -->

	6 <html>

	7 <head>

	8 <style>
	Lei Lei 2017/02/16 22:04:49 You can put those CSS code in a css file and inclu You can put those CSS code in a css file and include it here to reduce the duplicated code. bsheedy 2017/02/16 23:30:13 Done. Show quoted text On 2017/02/16 22:04:49, Lei Lei wrote: > You can put those CSS code in a css file and include it here to reduce the > duplicated code. Done.
	9 html, body {

	10 margin: 0;

	11 padding: 0;

	12 width: 100%;

	13 height: 100%;

	14 }

	15 #webgl-canvas {

	16 box-sizing: border-box;

	17 height: 100%;

	18 left: 0;

	19 margin: 0;

	20 position: absolute;

	21 top: 0;

	22 width: 100%;

	23 }

	24 #log {

	25 display: none;

	26 }

	27 </style>

	28 </head>

	29 <body>

	30 <canvas id="webgl-canvas"></canvas>

	31 <script src="../../../../../../third_party/WebKit/LayoutTests/resources/test harness.js"></script>

	32 <script src="../resources/webvr_e2e.js"></script>

	33 <script src="../resources/webvr_boilerplate.js"></script>
	Lei Lei 2017/02/16 22:04:49 I think you can remove this file in this test case I think you can remove this file in this test case, so you don't need to remove the event listener at the beginning to reduce the confusion. bsheedy 2017/02/16 23:30:13 Done. Show quoted text On 2017/02/16 22:04:49, Lei Lei wrote: > I think you can remove this file in this test case, so you don't need to remove > the event listener at the beginning to reduce the confusion. Done.
	34 <script>

	35 // Don't need to actually present for this test, so remove the listener

	36 window.removeEventListener("vrdisplayactivate", onVrRequestPresent);

	37

	38 var t = async_test("NFC scan fires the vrdisplayactivate event");

	39 window.addEventListener("vrdisplayactivate", () => {t.done();}, false);

	40 // NFC scan triggered after page load

	41 </script>

	42 </body>

	43 </html>

OLD	NEW