Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 25887005: Ignore the failure of this flaky PDF test. (Closed)

Created:
7 years, 2 months ago by scroggo
Modified:
7 years, 2 months ago
Reviewers:
edisonn, epoger
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Ignore the failure of this flaky PDF test. The Mac 10.6 seems to have a race condition that changes the output. Disable the test to avoid seeing this failure. R=edisonn@google.com Committed: https://code.google.com/p/skia/source/detail?r=11593

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add the bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scroggo
https://codereview.chromium.org/25887005/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json File expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json (left): https://codereview.chromium.org/25887005/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json#oldcode12298 expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json:12298: 1578 This bug refers to needing to review everything. ...
7 years, 2 months ago (2013-10-03 19:33:18 UTC) #1
edisonn
On 2013/10/03 19:33:18, scroggo wrote: > https://codereview.chromium.org/25887005/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json > File > expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json > (left): > > ...
7 years, 2 months ago (2013-10-03 19:41:40 UTC) #2
scroggo
On 2013/10/03 19:41:40, edisonn wrote: > On 2013/10/03 19:33:18, scroggo wrote: > > > https://codereview.chromium.org/25887005/diff/1/expectations/gm/Test-Mac10.6-MacMini4.1-GeForce320M-x86-Release/expected-results.json ...
7 years, 2 months ago (2013-10-03 20:19:56 UTC) #3
scroggo
Committed patchset #2 manually as r11593 (presubmit successful).
7 years, 2 months ago (2013-10-03 20:23:57 UTC) #4
epoger
7 years, 2 months ago (2013-10-07 18:33:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698