Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: ios/chrome/browser/share_extension/share_extension_item_receiver.mm

Issue 2588683002: Disable Share extension item receiver if there is no app group. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/share_extension/share_extension_item_receiver.mm
diff --git a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm
index 677f1ec931b4f7eb492774ca48c33413b1bb5297..a63334068cb0ad2dd50b566448eaeb6493f4f3b6 100644
--- a/ios/chrome/browser/share_extension/share_extension_item_receiver.mm
+++ b/ios/chrome/browser/share_extension/share_extension_item_receiver.mm
@@ -98,13 +98,9 @@ void LogHistogramReceivedItem(ShareExtensionItemReceived type) {
DCHECK(!_readingListModel);
DCHECK(!_bookmarkModel);
-#if TARGET_IPHONE_SIMULATOR
rohitrao (ping after 24h) 2016/12/19 09:40:33 We're running egtests on devices as well, that's w
sdefresne 2016/12/20 01:03:38 I think we should try to get the entitlements for
if (![self presentedItemURL]) {
return;
}
-#else
- DCHECK([self presentedItemURL]);
-#endif
_readingListModel = readingListModel;
_bookmarkModel = bookmarkModel;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698