third_party/WebKit/LayoutTests/http/tests/misc/acid3.html - Issue 2588643004: Allow positional selectors to match elements without a parent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/misc/acid3.html

Issue 2588643004: Allow positional selectors to match elements without a parent. (Closed)

Patch Set: Changed the expectation instead of the crashtest, since it felt a bit saner. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/LayoutTests/http/tests/misc/acid3.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/misc/acid3.html b/third_party/WebKit/LayoutTests/http/tests/misc/acid3.html

index f9cdc4c44c245427af3467d0f775023325120310..568fb543d457bbb71147e2634c40f9620e666423 100644

--- a/third_party/WebKit/LayoutTests/http/tests/misc/acid3.html

+++ b/third_party/WebKit/LayoutTests/http/tests/misc/acid3.html

@@ -1261,7 +1261,7 @@

var p1 = doc.createElement("p");

doc.body.appendChild(doc.createTextNode(" TEST "));

doc.body.appendChild(p1);

- expect(doc.documentElement, notFirst, "root element, with no parent node, claims to be a :first-child");

+ expect(doc.documentElement, first, "root element, with no parent node, claims to be a :first-child");

rune 2016/12/20 09:18:47 Right, we're breaking Acid3. That should be mentio

expect(doc.documentElement.firstChild, first, "first child of root node didn't match :first-child");

expect(doc.documentElement.firstChild.firstChild, first, "failure 3");

expect(doc.body, notFirst, "failure 4");