third_party/WebKit/LayoutTests/fast/selectors/child-indexed-pseudo-classes.html - Issue 2588643004: Allow positional selectors to match elements without a parent.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/selectors/child-indexed-pseudo-classes.html

Issue 2588643004: Allow positional selectors to match elements without a parent. (Closed)

Patch Set: Addressed review comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/css/first-letter-capitalized-edit-select-crash-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/misc/acid3.html » ('j') | third_party/WebKit/Source/core/dom/NthIndexCache.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <meta charset=utf-8>

	3 <title>Matching of child-indexed pseudo-classes</title>

	4 <link rel="author" title="Emilio Cobos Álvarez" href="mailto:ecoal95@gmail.com">

	5 <link rel="help" href="https://drafts.csswg.org/selectors-4/#child-index">

	6 <script src=../../resources/testharness.js></script>

	7 <script src=../../resources/testharnessreport.js></script>

	8 <script>

	9 test(function() {

	10 var check = function(element, selectors) {

	11 for (var i = 0; i < selectors.length; ++i) {

	12 var selector = selectors[i][0];

	13 var expected = selectors[i][1];

	14 assert_equals(expected, element.matches(selector),

	15 "Expected " + element.tagName + " element to " +

	16 (expected ? "match " : "not match ") + selector);

	17 }

	18 }

	19

	20 var rootOfSubtreeSelectors = [

	21 [ ":first-child", true ],

	22 [ ":last-child", true ],
	rune 2017/01/18 21:33:19 Test :only-child as well? Test :only-child as well? emilio 2017/01/18 23:33:07 Yeah, tested that and :only-of-type too, and query Show quoted text On 2017/01/18 21:33:19, rune wrote: > Test :only-child as well? Yeah, tested that and :only-of-type too, and querySelector/querySelectorAll on the document and a document fragment.
	23 [ ":first-of-type", true ],

	24 [ ":last-of-type", true ],

	25 [ ":nth-child(1)", true ],

	26 [ ":nth-child(n)", true ],

	27 [ ":nth-last-child(1)", true ],

	28 [ ":nth-last-child(n)", true ],

	29 [ ":nth-of-type(1)", true ],

	30 [ ":nth-of-type(n)", true ],

	31 [ ":nth-last-of-type(1)", true ],

	32 [ ":nth-last-of-type(n)", true ],

	33 [ ":nth-child(2)", false ],

	34 [ ":nth-last-child(2)", false],

	35 [ ":nth-of-type(2)", false ],

	36 [ ":nth-last-of-type(2)", false],

	37 ];

	38

	39 check(document.documentElement, rootOfSubtreeSelectors);

	40 check(document.createElement('div'), rootOfSubtreeSelectors);

	41 }, "child-indexed pseudo-classes should match without a parent")

	42 </script>

OLD	NEW