Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258863003: Don't throw an exception if onfullscreenchanged fires after the plugin is (Closed)

Created:
6 years, 8 months ago by Jamie
Modified:
6 years, 8 months ago
Reviewers:
Wez, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Don't throw an exception if onfullscreenchanged fires after the plugin is removed. We explicitly cancel full screen mode on disconnection, which was resulting in an exception in the event handler, preventing the full-screen class from being removed from the <html> node. The left the plugin container full-screen on top of the Disconnected dialog, making it unclickable. BUG=365920 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M remoting/webapp/client_session.js View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Jamie
ptal
6 years, 8 months ago (2014-04-25 20:35:14 UTC) #1
kelvinp
lgtm
6 years, 8 months ago (2014-04-25 21:03:32 UTC) #2
Jamie
Can I get an LGTM from a committer as well please?
6 years, 8 months ago (2014-04-25 21:05:59 UTC) #3
Wez
lgtm
6 years, 8 months ago (2014-04-25 21:43:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/258863003/1
6 years, 8 months ago (2014-04-25 22:29:44 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 00:30:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 00:30:41 UTC) #7
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 8 months ago (2014-04-26 04:18:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/258863003/1
6 years, 8 months ago (2014-04-26 04:20:21 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 05:15:20 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-26 05:15:21 UTC) #11
Jamie
The CQ bit was checked by jamiewalch@chromium.org
6 years, 8 months ago (2014-04-26 17:47:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/258863003/1
6 years, 8 months ago (2014-04-26 17:48:15 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 07:15:34 UTC) #14
Message was sent while issue was closed. 
Change committed as 266464

Powered by Google App Engine
This is Rietveld 408576698