Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 25886002: Move TextStream to Source/platform/text/ (Closed)

Created:
7 years, 2 months ago by pilgrim_google
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, kenneth.christiansen, jamesr, danakj, dsinclair, eae+blinkwatch, leviw+renderwatch, blink-layers+watch_chromium.org, Rik, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, pdr., darin (slow to review)
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -239 lines) Patch
M Source/core/core.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/FrameView.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEBlend.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEColorMatrix.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEComponentTransfer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEComposite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEConvolveMatrix.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEDiffuseLighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEDropShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEFlood.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEGaussianBlur.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/FEMerge.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FEMorphology.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/platform/graphics/filters/FEOffset.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FESpecularLighting.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FETile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/FETurbulence.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/platform/graphics/filters/PointLightSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/SourceAlpha.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/SourceGraphic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/filters/custom/FECustomFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
D Source/core/platform/text/TextStream.h View 1 chunk +0 lines, -64 lines 0 comments Download
D Source/core/platform/text/TextStream.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
M Source/core/rendering/RenderTreeAsText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/filters/SVGFEImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + Source/platform/text/TextStream.h View 1 chunk +2 lines, -1 line 0 comments Download
A + Source/platform/text/TextStream.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
pilgrim_google
7 years, 2 months ago (2013-10-03 15:09:09 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-03 18:31:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25886002/1
7 years, 2 months ago (2013-10-03 18:32:30 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout for step(s) webkit_lint http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout&number=10964
7 years, 2 months ago (2013-10-04 02:20:14 UTC) #4
pilgrim_google
rebase
7 years, 2 months ago (2013-10-04 02:30:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/25886002/17001
7 years, 2 months ago (2013-10-04 02:31:29 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 2 months ago (2013-10-04 06:28:46 UTC) #7
pilgrim_google
7 years, 2 months ago (2013-10-04 13:50:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r158930 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698