Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html

Issue 2588503002: DevTools: Cache the original content on UISourceCode (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js » ('j') | third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
diff --git a/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html b/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
index 4f09e840340ad13bd6c07cd3618eb010b6bc4632..8fd00fb85b9807cf80b84f1ca057958c3859f082 100644
--- a/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
+++ b/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html
@@ -19,7 +19,7 @@ function test()
}
return project;
}
-
+
function dumpUISourceCodeWithRevisions(uiSourceCode)
{
var content = uiSourceCode._content;
@@ -38,78 +38,82 @@ function test()
function testAddRevisionsRevertToOriginal(next)
{
var uiSourceCode = new Workspace.UISourceCode(createMockProject(), "url", Common.resourceTypes.Script);
- uiSourceCode.setWorkingCopy("content1");
- uiSourceCode.setWorkingCopy("content2");
- uiSourceCode.commitWorkingCopy(function() { });
-
- InspectorTest.addResult("First revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.setWorkingCopy("content3");
- uiSourceCode.setWorkingCopy("content4");
- uiSourceCode.commitWorkingCopy(function() { });
+ uiSourceCode.requestContent().then( () => {
einbinder 2016/12/16 23:43:00 We need to signal our intention to use this uiSour
+ uiSourceCode.setWorkingCopy("content1");
+ uiSourceCode.setWorkingCopy("content2");
+ uiSourceCode.commitWorkingCopy(function() { });
- InspectorTest.addResult("Second revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.revertToOriginal().then(onReverted);
+ InspectorTest.addResult("First revision added.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ uiSourceCode.setWorkingCopy("content3");
+ uiSourceCode.setWorkingCopy("content4");
+ uiSourceCode.commitWorkingCopy(function() { });
- function onReverted()
- {
- InspectorTest.addResult("Reverted to original.");
+ InspectorTest.addResult("Second revision added.");
dumpUISourceCodeWithRevisions(uiSourceCode);
- next();
- }
+ uiSourceCode.revertToOriginal().then(onReverted);
+
+ function onReverted()
+ {
+ InspectorTest.addResult("Reverted to original.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ next();
+ }
+ });
},
function testAddRevisionsRevertAndClearHistory(next)
{
var uiSourceCode = new Workspace.UISourceCode(createMockProject(), "url2", Common.resourceTypes.Script);
+ uiSourceCode.requestContent().then( () => {
+ uiSourceCode.setWorkingCopy("content1");
+ uiSourceCode.setWorkingCopy("content2");
+ uiSourceCode.commitWorkingCopy(function() { });
- uiSourceCode.setWorkingCopy("content1");
- uiSourceCode.setWorkingCopy("content2");
- uiSourceCode.commitWorkingCopy(function() { });
-
- InspectorTest.addResult("First revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.setWorkingCopy("content3");
- uiSourceCode.setWorkingCopy("content4");
- uiSourceCode.commitWorkingCopy(function() { });
-
- InspectorTest.addResult("Second revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.revertAndClearHistory(revertedAndClearedHistory);
+ InspectorTest.addResult("First revision added.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ uiSourceCode.setWorkingCopy("content3");
+ uiSourceCode.setWorkingCopy("content4");
+ uiSourceCode.commitWorkingCopy(function() { });
- function revertedAndClearedHistory()
- {
- InspectorTest.addResult("Reverted and cleared history.");
+ InspectorTest.addResult("Second revision added.");
dumpUISourceCodeWithRevisions(uiSourceCode);
- next();
- }
+ uiSourceCode.revertAndClearHistory(revertedAndClearedHistory);
+
+ function revertedAndClearedHistory()
+ {
+ InspectorTest.addResult("Reverted and cleared history.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ next();
+ }
+ });
},
function testAddRevisionsRevertToPrevious(next)
{
var uiSourceCode = new Workspace.UISourceCode(createMockProject(), "url3", Common.resourceTypes.Script);
+ uiSourceCode.requestContent().then( () => {
+ uiSourceCode.setWorkingCopy("content1");
+ uiSourceCode.setWorkingCopy("content2");
+ uiSourceCode.commitWorkingCopy(function() { });
- uiSourceCode.setWorkingCopy("content1");
- uiSourceCode.setWorkingCopy("content2");
- uiSourceCode.commitWorkingCopy(function() { });
-
- InspectorTest.addResult("First revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.setWorkingCopy("content3");
- uiSourceCode.setWorkingCopy("content4");
- uiSourceCode.commitWorkingCopy(function() { });
-
- InspectorTest.addResult("Second revision added.");
- dumpUISourceCodeWithRevisions(uiSourceCode);
- uiSourceCode.history[0].revertToThis().then(onReverted);
+ InspectorTest.addResult("First revision added.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ uiSourceCode.setWorkingCopy("content3");
+ uiSourceCode.setWorkingCopy("content4");
+ uiSourceCode.commitWorkingCopy(function() { });
- function onReverted()
- {
- InspectorTest.addResult("Reverted to previous revision.");
+ InspectorTest.addResult("Second revision added.");
dumpUISourceCodeWithRevisions(uiSourceCode);
- next();
- }
+ uiSourceCode.history[0].revertToThis().then(onReverted);
+
+ function onReverted()
+ {
+ InspectorTest.addResult("Reverted to previous revision.");
+ dumpUISourceCodeWithRevisions(uiSourceCode);
+ next();
+ }
+ });
},
function testRequestContentAddRevisionsRevertToOriginal(next)
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js » ('j') | third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698