Source/core/frame/DOMWindow.h - Issue 258843002: Remove unsound asserts in the DOMWindow destructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/DOMWindow.h

Issue 258843002: Remove unsound asserts in the DOMWindow destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Invert and use ASSERT_ENABLED Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/DOMWindow.h

diff --git a/Source/core/frame/DOMWindow.h b/Source/core/frame/DOMWindow.h

index bd15d1948f3c15cf29d65b23f5363e0defc38a48..2dd0cc3d6a02cd116535cbb41e9826b1b9196a59 100644

--- a/Source/core/frame/DOMWindow.h

+++ b/Source/core/frame/DOMWindow.h

@@ -346,6 +346,9 @@ enum PageshowEventPersistence {

RefPtr<Document> m_document;

bool m_shouldPrintWhenFinishedLoading;

+#if ASSERT_ENABLED

+ bool m_hasBeenReset;

+#endif

HashSet<DOMWindowProperty*> m_properties;

« no previous file with comments | « LayoutTests/fast/dom/Window/Location/set-location-after-close-expected.txt ('k') | Source/core/frame/DOMWindow.cpp » ('j') | no next file with comments »