third_party/WebKit/public/platform/Platform.h - Issue 2588403002: TestingPlatformSupport: register Platform instance correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/Platform.h

Issue 2588403002: TestingPlatformSupport: register Platform instance correctly (Closed)

Patch Set: review #16 and merge master Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/platform/Platform.h

diff --git a/third_party/WebKit/public/platform/Platform.h b/third_party/WebKit/public/platform/Platform.h

index 8c569a75d7f6661186734e11b8fcaa46690a2bb3..9c96d16094cb6b9a272679109d467306f2018d89 100644

--- a/third_party/WebKit/public/platform/Platform.h

+++ b/third_party/WebKit/public/platform/Platform.h

@@ -139,7 +139,9 @@ class BLINK_PLATFORM_EXPORT Platform {

static void shutdown();

static Platform* current();

- // Used to switch the current platform only for testing.

+ // Used to switch the current platform only for testing. Since this method

+ // calls virtual methods internally, you should not call with self instance

+ // inside a Platform subclass's constructor.

static void setCurrentPlatformForTesting(Platform*);

// May return null.