third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp - Issue 2588403002: TestingPlatformSupport: register Platform instance correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

Issue 2588403002: TestingPlatformSupport: register Platform instance correctly (Closed)

Patch Set: review #16 and merge master Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp ('K') | « third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp ('k') | third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp » ('j') | third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

diff --git a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

index 551005152cb1f4df5feb938782ca4236a1c40ae8..7478fa51acbc146f5353659bd7e295b0f4509cb1 100644

--- a/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

+++ b/third_party/WebKit/Source/modules/compositorworker/AnimationWorkletThreadTest.cpp

@@ -85,6 +85,7 @@ class AnimationWorkletTestPlatform : public TestingPlatformSupport {

class AnimationWorkletThreadTest : public ::testing::Test {

public:

void SetUp() override {

+ m_testPlatform.reset(WTF::makeUnique<AnimationWorkletTestPlatform>());

AnimationWorkletThread::createSharedBackingThreadForTest();

m_reportingProxy = TestAnimationWorkletReportingProxy::create();

m_securityOrigin =

@@ -128,7 +129,7 @@ class AnimationWorkletThreadTest : public ::testing::Test {

RefPtr<SecurityOrigin> m_securityOrigin;

std::unique_ptr<WorkerReportingProxy> m_reportingProxy;

- AnimationWorkletTestPlatform m_testPlatform;

+ ScopedTestingPlatformSupport<AnimationWorkletTestPlatform> m_testPlatform;

};

TEST_F(AnimationWorkletThreadTest, Basic) {